Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd:chunked convert_images: Do the conversion in GetDiffer? #2032

Open
mtrmac opened this issue Jul 16, 2024 · 0 comments
Open

zstd:chunked convert_images: Do the conversion in GetDiffer? #2032

mtrmac opened this issue Jul 16, 2024 · 0 comments

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 16, 2024

c/image calls chunked.GetDiffer immediately followed by store.ApplyDiffWithDiffer ~ differ.ApplyDiff.

Currently convert_images happens in the latter call; but that means it happens with the layer store locked for writing. It seems to me that moving the conversion to the GetDiffer phase would increase opportunities for concurrency, especially for slow networks. (And it would probably simplify the data stored in chunkedDiffer and the ApplyDiff implementation a bit.)

Cc: @giuseppe . This is certainly not urgent, and might even not be desirable to do right now — but I hear performance of this code path is a concern, so this might be worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant