Skip to content

kube play with sdnotify=conmon: Error: Closing notify proxy: close unixgram: use of closed network connection #19715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edsantiago opened this issue Aug 23, 2023 · 5 comments · Fixed by #19727
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

$ cat >/tmp/foo.yaml <<EOF
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: test
  name: test_pod
  annotations:
    io.containers.sdnotify: conmon
spec:
  restartPolicy: Never
  containers:
    - name: ctr1
      image: quay.io/libpod/testimage:20221018
      command:
      - true
EOF
$ bin/podman kube play /tmp/foo.yaml
ERRO[0001] Closing notify proxy "/dev/shm/-podman-notify-proxy.sock146894828": close unixgram /dev/shm/-podman-notify-proxy.sock146894828: use of closed network connection 
Pod:
2c0e114741a88f943b8483f56e57d604620cd12c03334080e3a9ea92555a1246
Container:
ade31f15fdc15685d03586067948d1d2d5a5c1e11c90938e5484f6050b9680d2

100% reproducible on my f38 laptop, not a flake. This is the source of the .sock file:

// New creates a NotifyProxy that starts listening immediately. The specified
// temp directory can be left empty.
func New(tmpDir string) (*NotifyProxy, error) {
tempFile, err := os.CreateTemp(tmpDir, "-podman-notify-proxy.sock")

@vrothberg
Copy link
Member

Will look into it, thanks @edsantiago !

@vrothberg
Copy link
Member

This really only works with --service-container. I will reflect a bit more on it tomorrow with a less fried brain #toohot

@edsantiago
Copy link
Member Author

I'm not sure how to parse "only works" (maybe "should only work with --service-container", or "currently only work with ..."?). Anyhow, adding --service-container makes no difference. Same warning/error message. (This was discovered by accident in the "propagation" test in 260-sdnotify.bats, which always runs with --service-container).

And, this can wait. Stay cool.

@edsantiago
Copy link
Member Author

git-bisect identifies #16709 as the culprit, which is unsurprising since that's where the "Closing notify proxy" message came in.

@vrothberg
Copy link
Member

Opened #19727

vrothberg added a commit to vrothberg/libpod that referenced this issue Aug 24, 2023
Do not close a notifyproxy more than once.  Also polish the backend a
bit to reflect ealier changes from commit 4fa307f.

Fixes: containers#19715
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants