Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: name filter in images.list() #468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: name filter in images.list() #468

wants to merge 2 commits into from
+13 −9

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #457

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mr-Sunglasses
Once this PR has been reviewed and has the lgtm label, please assign mwhahaha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2024

@umohnani8 @jwhonce @inknos PTAL

@inknos inknos self-requested a review November 19, 2024 14:35
inknos
inknos requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@inknos inknos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Mr-Sunglasses thanks for the PR. it looks good although there are a few things that the CI is complaining about, I can take a look into these as they seem unrelated.

The PR is good. Would you like to write some tests for filter?

You can take inspiration from these prs #462 #460 and if you have questions I can help you if you need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inknos inknos inknos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] images.list() filter does not work properly
3 participants
@Mr-Sunglasses @rhatdan @inknos