Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Provide a way to verify create container kwargs #407

Open
ogajduse opened this issue Jul 10, 2024 · 1 comment
Open

RFE: Provide a way to verify create container kwargs #407

ogajduse opened this issue Jul 10, 2024 · 1 comment
Assignees

Comments

@ogajduse
Copy link

docker-py provides two constants RUN_CREATE_KWARGS and RUN_HOST_CONFIG_KWARGS that a consumer might use to validate kwargs they are passing to the CreateMixin.create method.

https://github.com/docker/docker-py/blob/a3652028b1ead708bd9191efb286f909ba6c2a49/docker/models/containers.py#L1122-L1134

I would like podman-py to provide either similar kinds of constants like docker-py does or provide a public method that could be used to validate the kwargs.

Currently, we have the following workaround implemented:
https://github.com/SatelliteQE/broker/blob/eab6d4596d1b729bf86cc2dcd1bcae87e08a576a/broker/binds/containers.py#L150-L165

@ogajduse
Copy link
Author

In our DockerBind class, the implementation of the same method is using the constants that are mentioned in the issue description.

https://github.com/SatelliteQE/broker/blob/eab6d4596d1b729bf86cc2dcd1bcae87e08a576a/broker/binds/containers.py#L181-L184

@inknos inknos self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants