Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken #299

Closed
cevich opened this issue Jul 3, 2023 · 2 comments
Closed

CI is broken #299

cevich opened this issue Jul 3, 2023 · 2 comments

Comments

@cevich
Copy link
Member

cevich commented Jul 3, 2023

It looks like #297 was merged w/o passing CI tests. I'm not sure why/how all the CI tests there are marked "Canceled" - maybe b/c renovate tried to update the PR just as merge button was clicked? Either way, the previous run also failed CI in the same way.

Anyway, this change is now failing CI tests on main. Looks like a python-3.6 incompatibility. That means every PR opened or rebased with this changed will also fail CI.

py36: install_deps> pip install -r /var/tmp/go/src/github.com/containers/podman-py/test-requirements.txt
  Could not find a version that satisfies the requirement fixtures~=4.1.0 (from -r /var/tmp/go/src/github.com/containers/podman-py/test-requirements.txt (line 5)) (from versions: 0.1, 0.2, 0.3, 0.3.1, 0.3.2, 0.3.3, 0.3.4, 0.3.5, 0.3.6, 0.3.7, 0.3.8, 0.3.9, 0.3.10, 0.3.11, 0.3.12, 0.3.13, 0.3.14, 0.3.15, 0.3.16, 0.3.17, 1.0.0, 1.1.0, 1.2.0, 1.2.1, 1.3.0, 1.3.1, 1.3.2.dev6, 1.4.0, 2.0.0, 3.0.0, 4.0.0, 4.0.1)
No matching distribution found for fixtures~=4.1.0 (from -r /var/tmp/go/src/github.com/containers/podman-py/test-requirements.txt (line 5))
...cut...
  pylint: OK (26.62=setup[15.11]+cmd[11.51] seconds)
  coverage: OK (64.43=setup[19.68]+cmd[44.28,0.47] seconds)
  py36: FAIL code 1 (4.54 seconds)
  py38: OK (60.40=setup[20.35]+cmd[40.05] seconds)
  py39: OK (59.85=setup[20.48]+cmd[39.38] seconds)
  py310: OK (59.62=setup[19.69]+cmd[39.93] seconds)
  py311: OK (55.21=setup[15.19]+cmd[40.03] seconds)
  evaluation failed :( (333.95 seconds)

@rhatdan or @umohnani8 any idea what we should do here? For CI, maybe we could somehow tell CI for 3.6 to use the old version? Otherwise clearly this will (at a minimum) fail to run RHEL (due to fixtures incompatibility with 3.6). A more drastic option (but likely to work) is to revert that commit.

@rhatdan
Copy link
Member

rhatdan commented Jul 4, 2023

Lets revert the fix and figure out how we can get this updated for RHEL.

@cevich
Copy link
Member Author

cevich commented Jul 5, 2023

Looks like Urvashi figured out a fix in #300

@cevich cevich closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants