extension may stuck in activating state if dispose are never ending

[axel7083]

Bug description

Reading carefully the logs in #9370 (comment) we have the following

Activating extension podman-desktop.podman failed error:Error: Extension podman-desktop.podman activation timed out after 20 seconds

which correspond to the following console.log

podman-desktop/packages/main/src/plugin/extension-loader.ts

Line 1639 in 6c8c434

console.log(`Activating extension ${extension.id} failed error:${err}`);

However; a per the user state: we never the extension state to failed, still on activate, meaning something went wrong in those lines

podman-desktop/packages/main/src/plugin/extension-loader.ts

Lines 1639 to 1650 in 6c8c434

	console.log(`Activating extension ${extension.id} failed error:${err}`);
	// dispose resources
	for (const subscription of extensionContext.subscriptions) {
	try {
	subscription.dispose();
	} catch (err: unknown) {
	console.error('Something went wrong while trying to dispose extension subscription', err);
	}
	}
	this.extensionState.set(extension.id, 'failed');

We are iterating in the subscriptions, and disposing them in a try catch, but here is the catch... we do not set timeout to them, but... they are not promises, they should not take too much time ??

Podman is adding tons of disposales, some of them very heavy

podman-desktop/extensions/podman/packages/extension/src/extension.ts

Lines 1561 to 1563 in d11a6f9

	const disposable = extensionApi.Disposable.create(() => {
	podmanProcess.kill();
	});

Operating system

Windows 11

Installation Method

Other

Version

next (development version)

Steps to reproduce

#9370

Relevant log output

No response

Additional context

No response

[axel7083]

If the problem is coming from disposal never ending, this is tricky, and bad. But we could work around by appliying a race condition between a setTimeout and the disposals, or moving the setState error above, but we could have a state where some resources are yet not disposed, and the extension may restarted.

IMO the timeout race is an acceptable solution :/

[jeffmaury]

I have a reproducer:

• have 2 podman machine started
• start podman desktop
• the podman extension will display a dialog about the podman default connection not in sync with the podman machine
• wait at least 20 seconds to answer to the dialog --> extension start elapsed

[odockal]

I have a reproducer:

* have 2 podman machine started

* start podman desktop

* the podman extension will display a dialog about the podman default connection not in sync with the podman machine

* wait at least 20 seconds to answer to the dialog --> extension start elapsed

Moreover, in this state extension cannot be activated anymore in running Podman Desktop. The error says:

Activating extension podman-desktop.podman failed error:Error: command 'podman.onboarding.checkInstalledCommand' already exists