Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

write: support xz compression #149

Open
blalor opened this issue Dec 9, 2015 · 3 comments
Open

write: support xz compression #149

blalor opened this issue Dec 9, 2015 · 3 comments

Comments

@blalor
Copy link
Contributor

blalor commented Dec 9, 2015

It's more CPU-intensive, but results in much smaller ACIs.

@krobertson
Copy link
Contributor

The reason I didn't add it when initially adding the compression support was because it'd add the dynamic library dependency. I don't like the compression handling that shells out to xz, but the dynamic linking then makes it required on the host.

One thing that may be worth trying though would be to make the pre-compiled binaries with each release be statically compiled...

@cgonyeo
Copy link
Member

cgonyeo commented Dec 9, 2015

I'd be in favor of exploring statically compiled releases. It'd also help prevent other issues like when I accidentally build releases on NixOS: #133. There does appear to be a pure golang xz package, but it isn't stable so it's probably not worth it: https://github.com/ulikunitz/xz.

@jonboulle
Copy link
Contributor

IIRC statically linking is probably not feasible because of resolver issues.

But in any case I don't understand how that relates exactly to the xz case? What does shelling out have to do with dynamic linking? unless you're suggesting baking a copy of xz into the releases or something..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants