check if snapshot holds mountpoint before remove #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaberZhuang
force-pushed
the
main
branch
3 times, most recently
from
27f06a5
to
2c7f96e
Compare
BigVan
reviewed
Sep 12, 2024
pkg/snapshot/overlay.go
Outdated
| @@ -980,6 +990,19 @@ func (o *snapshotter) Remove(ctx context.Context, key string) (err error) { | |||
| return nil | |||
| } | |||
|
|
|||
| func (o *snapshotter) hasMountpoint(ctx context.Context, id string) (bool, error) { | |||
| if out, err := exec.CommandContext(ctx, "/bin/bash", "-c", | |||
There was a problem hiding this comment.
create a process to check mount point is so tricky.
Signed-off-by: zhuangbowei.zbw <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enhance snapshotter.Remove to avoid delete snapshots which hold a mountpoint.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: