Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of checkpoints in iss.go #486

Open
matejpavlovic opened this issue Jul 8, 2023 · 1 comment
Open

Conversion of checkpoints in iss.go #486

matejpavlovic opened this issue Jul 8, 2023 · 1 comment

Comments

@matejpavlovic
Copy link
Contributor

The checkpoints handled in iss.go are sometimes converted back and forth between their generated types and the underlying protobufs. These conversions look quite meaningless. Check where there is really no purpose to those conversions and remove them if possible.

@matejpavlovic
Copy link
Contributor Author

This is, actually, just an awkward way of converting a mir-generated checkpoint type to the "native" checkpoint type through a "raw" protobuf. What needs to be cleaned up is loading checkpoints directly from the mir-generated types, not from the raw protobuf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant