Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLD Resolver Bitswap not working with 0.53 upgrade #537

Open
aakoshh opened this issue Jan 11, 2024 · 0 comments
Open

IPLD Resolver Bitswap not working with 0.53 upgrade #537

aakoshh opened this issue Jan 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Jan 11, 2024

#522 upgrades the libp2p version to 0.53 and depends on consensus-shipyard/libp2p-bitswap#1 for upgrading the libp2p-bitswap library we use.

As noted in the PR, one of the smoke tests in the resolver, the one which tests bitswap, stopped working. It makes some progress (visible if we add some extra logging), but never reaches completion. I tried on the original repo and it works with 5000 entries in the HAMT, yet here it doesn't work with 1000; 500 seems to work, maybe because it requires a smaller number of requests.

We have to check what kind of problem we introduced to libp2p-bitswap with either our changes, or the upgrade to 0.53

Fendermint currently doesn't use the Bitswap functionality, we are only interested in the voting at this point, which seems to work, but this should be fixed.

@aakoshh aakoshh added the bug Something isn't working label Jan 11, 2024
@jsoares jsoares closed this as completed Mar 19, 2024
@jsoares jsoares reopened this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants