Fix bug in CFG with while true loops

[anthonyyangdev]

Prevent nodes with side effects from being unintentionally looped.
Check this issue in AsmCFG and IrCFG

[whoiswillma]

I thought this issue was resolved in the IR CFG constructor?

If it's not, can you tackle this one? Seemed like you had this one figured out

[anthonyyangdev]

Resolved, but it may not necessarily be the best solution. Recall it was done by adding an if node that just loops to itself. It might be better to introduce a nop node that loops to itself instead which can then be removed when going from CFG to IR.

I might need to be more careful with AsmCFG though since we are also keeping track of index numbers with the cfg nodes, but I can look into this issue.

[anthonyyangdev]

Fixed issue with while loops for IR CFGs in branch copy-prop