Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

[engine] Fix withdrawal fee estimates #493

Open
LayneHaber opened this issue Mar 22, 2021 · 0 comments
Open

[engine] Fix withdrawal fee estimates #493

LayneHaber opened this issue Mar 22, 2021 · 0 comments
Labels
bug Something isn't working p2 Non-critical change

Comments

@LayneHaber
Copy link
Contributor

Describe the bug
Withdrawals use a hardcoded fee because they cannot estimate without sigs. This does not account for the WithdrawHelper calls. We should be estimating the WithdrawHelper fees and adding those into the amount we account for in the gas calculations.

During implementation should also consider the edge case where the quote is requested without a callData field, and callData is supplied to the engine API. (Quote should not be valid in this case)

@LayneHaber LayneHaber added bug Something isn't working p2 Non-critical change labels Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working p2 Non-critical change
Projects
None yet
Development

No branches or pull requests

1 participant