Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mocking of gRPC-web and Connect GET requests #100
Fix mocking of gRPC-web and Connect GET requests #100
Changes from 4 commits
c26ef2a
98e11c8
d9447c1
c4c08b9
07faa38
bbe18c6
d129330
2611c79
31203a6
3c307cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
body
property of the typeUniversalServerRequest
isAsyncIterable<Uint8Array> | JsonValue
. We're still passing in other types here. We do not need to special case the gRPC-web content type, only application/json.Please update
let body: any
to not useany
- this is how this bug slipped in in the first place. I suggest we uselet body: UniversalServerRequest["body"]
.