Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buf build buf.gen.yaml instructions for connectrpc/kotlin don't mention protocolbuffers version #299

Closed
q42jaap opened this issue Jul 10, 2024 · 2 comments

Comments

@q42jaap
Copy link

q42jaap commented Jul 10, 2024

https://buf.build/connectrpc/kotlin?version=v0.6.1
The docs for connectrpc/kotlin don't mention the version of buf.build/protocolbuffers/kotlin this depends on.
for 0.6.1 it should be buf.build/protocolbuffers/kotlin:26.1
for 0.7.0 it should be buf.build/protocolbuffers/kotlin:27.2

If this could be added to buf.build this would be very helpful in avoiding mistakes.

Also, the release notes of 0.7.0 don't mention the protocolbuffers version.

The runtime error protocolbuffers gives is easy enough to understand, but it still took us some time and caused a bit of confusion.

@pkwarren
Copy link
Contributor

I'll log a ticket for the BSR around plugin version dependencies, however the connectrpc org isn't a great place to track these. In the meantime I'll close this ticket and let you know if we should create it in another repo.

Also, the release notes of 0.7.0 don't mention the protocolbuffers version.

See under "Other Changes": https://github.com/connectrpc/connect-kotlin/releases/tag/v0.7.0

@pkwarren pkwarren closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@pkwarren
Copy link
Contributor

@q42jaap - We've updated the BSR to pin the version of plugin dependencies in the example buf.gen.yaml files that should hopefully avoid issues like this in the future: https://buf.build/connectrpc/kotlin?version=v0.7.0

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants