From c8e4b1ca6c3bcb1b053ac44b33d818f866a25fb4 Mon Sep 17 00:00:00 2001 From: Josh Humphries <2035234+jhump@users.noreply.github.com> Date: Mon, 29 Jan 2024 21:11:16 -0500 Subject: [PATCH] enable new conformance tests for streams --- Makefile | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index c5d92f40..b247c774 100644 --- a/Makefile +++ b/Makefile @@ -69,16 +69,12 @@ runconformancenew: generate $(CONNECT_CONFORMANCE) ## Run the new conformance te --known-failing conformance/client/known-failing-unary-cases.txt -- \ conformance/client/google-java/build/install/google-java/bin/google-java \ --style blocking - -# TODO: Add streaming conformance tests. Currently, a small number of the test cases -# are flaky, so leaving this commented out for now. -# (Will continue investigating and address soon). -# $(CONNECT_CONFORMANCE) -v --mode client --conf conformance/client/lite-stream-config.yaml \ -# --known-failing conformance/client/known-failing-stream-cases.txt -- \ -# conformance/client/google-javalite/build/install/google-javalite/bin/google-javalite -# $(CONNECT_CONFORMANCE) -v --mode client --conf conformance/client/standard-stream-config.yaml \ -# --known-failing conformance/client/known-failing-stream-cases.txt -- \ -# conformance/client/google-java/build/install/google-java/bin/google-java + $(CONNECT_CONFORMANCE) -v --mode client --conf conformance/client/lite-stream-config.yaml \ + --known-failing conformance/client/known-failing-stream-cases.txt -- \ + conformance/client/google-javalite/build/install/google-javalite/bin/google-javalite + $(CONNECT_CONFORMANCE) -v --mode client --conf conformance/client/standard-stream-config.yaml \ + --known-failing conformance/client/known-failing-stream-cases.txt -- \ + conformance/client/google-java/build/install/google-java/bin/google-java .PHONY: runcrosstests runcrosstests: generate ## Run the old cross-test suite.