From 9590919d4c10acabd80d538a0d289b15abf523f4 Mon Sep 17 00:00:00 2001
From: Josh Humphries <2035234+jhump@users.noreply.github.com>
Date: Mon, 29 Jan 2024 20:31:04 -0500
Subject: [PATCH] fixup conformance config files: opt out of client message
 size tests w/ config instead of known-failing

---
 .../client/known-failing-stream-cases.txt       | 17 ++++-------------
 conformance/client/lite-stream-config.yaml      |  1 +
 conformance/client/lite-unary-config.yaml       |  1 +
 conformance/client/standard-stream-config.yaml  |  1 +
 conformance/client/standard-unary-config.yaml   |  1 +
 5 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/conformance/client/known-failing-stream-cases.txt b/conformance/client/known-failing-stream-cases.txt
index a84a57cd..9589a7ce 100644
--- a/conformance/client/known-failing-stream-cases.txt
+++ b/conformance/client/known-failing-stream-cases.txt
@@ -1,15 +1,6 @@
-# OkHttp seems to have a bug where timeout is not properly
-# enforced when request body is full-duplex.
+# We currently rely on OkHttp's "call timeout" to handle
+# RPC deadlines, but that is not enforced when the request
+# body is duplex. So timeouts don't currently work with
+# bidi streams.
 Timeouts/HTTPVersion:2/**/bidi half duplex timeout
 Timeouts/HTTPVersion:2/**/bidi full duplex timeout
-
-# Connect-kotlin does not have a way to limit the size of messages
-# received. It probably should. Despite this, many cases in this suite
-# still pass, so they are likely not exercising what we think they are.
-# TODO: add flag to config yaml for whether implementation supports
-#       a receive size limit
-Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream first request exceeds client limit
-Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream subsequent request exceeds client limit
-Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream all requests equal to client limit
-Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/server stream request equal to client limit
-Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/server stream request exceeds client limit
diff --git a/conformance/client/lite-stream-config.yaml b/conformance/client/lite-stream-config.yaml
index 5cdb0c8b..45049aa8 100644
--- a/conformance/client/lite-stream-config.yaml
+++ b/conformance/client/lite-stream-config.yaml
@@ -23,3 +23,4 @@ features:
     - STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
   # TODO: get client certs working and uncomment this
   #supportsTlsClientCerts: true
+  supportsMessageReceiveLimit: false
\ No newline at end of file
diff --git a/conformance/client/lite-unary-config.yaml b/conformance/client/lite-unary-config.yaml
index ac4aeb7c..abdee3a0 100644
--- a/conformance/client/lite-unary-config.yaml
+++ b/conformance/client/lite-unary-config.yaml
@@ -22,3 +22,4 @@ features:
     - STREAM_TYPE_UNARY
   # TODO: get client certs working and uncomment this
   #supportsTlsClientCerts: true
+  supportsMessageReceiveLimit: false
\ No newline at end of file
diff --git a/conformance/client/standard-stream-config.yaml b/conformance/client/standard-stream-config.yaml
index 1b3f284f..14ede665 100644
--- a/conformance/client/standard-stream-config.yaml
+++ b/conformance/client/standard-stream-config.yaml
@@ -23,3 +23,4 @@ features:
     - STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
   # TODO: get client certs working and uncomment this
   #supportsTlsClientCerts: true
+  supportsMessageReceiveLimit: false
\ No newline at end of file
diff --git a/conformance/client/standard-unary-config.yaml b/conformance/client/standard-unary-config.yaml
index fb10401a..78649614 100644
--- a/conformance/client/standard-unary-config.yaml
+++ b/conformance/client/standard-unary-config.yaml
@@ -22,3 +22,4 @@ features:
     - STREAM_TYPE_UNARY
   # TODO: get client certs working and uncomment this
   #supportsTlsClientCerts: true
+  supportsMessageReceiveLimit: false
\ No newline at end of file