Skip to content

Commit

Permalink
fixup conformance config files: opt out of client message size tests …
Browse files Browse the repository at this point in the history
…w/ config instead of known-failing
  • Loading branch information
jhump committed Jan 31, 2024
1 parent af4822f commit 54f5b5c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 13 deletions.
17 changes: 4 additions & 13 deletions conformance/client/known-failing-stream-cases.txt
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
# OkHttp seems to have a bug where timeout is not properly
# enforced when request body is full-duplex.
# We currently rely on OkHttp's "call timeout" to handle
# RPC deadlines, but that is not enforced when the request
# body is duplex. So timeouts don't currently work with
# bidi streams.
Timeouts/HTTPVersion:2/**/bidi half duplex timeout
Timeouts/HTTPVersion:2/**/bidi full duplex timeout

# Connect-kotlin does not have a way to limit the size of messages
# received. It probably should. Despite this, many cases in this suite
# still pass, so they are likely not exercising what we think they are.
# TODO: add flag to config yaml for whether implementation supports
# a receive size limit
Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream first request exceeds client limit
Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream subsequent request exceeds client limit
Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/client stream all requests equal to client limit
Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/server stream request equal to client limit
Client Message Size/**/Compression:COMPRESSION_GZIP/TLS:false/**/server stream request exceeds client limit
1 change: 1 addition & 0 deletions conformance/client/lite-stream-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ features:
- STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
# TODO: get client certs working and uncomment this
#supportsTlsClientCerts: true
supportsMessageReceiveLimit: false
1 change: 1 addition & 0 deletions conformance/client/lite-unary-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ features:
- STREAM_TYPE_UNARY
# TODO: get client certs working and uncomment this
#supportsTlsClientCerts: true
supportsMessageReceiveLimit: false
1 change: 1 addition & 0 deletions conformance/client/standard-stream-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ features:
- STREAM_TYPE_FULL_DUPLEX_BIDI_STREAM
# TODO: get client certs working and uncomment this
#supportsTlsClientCerts: true
supportsMessageReceiveLimit: false
1 change: 1 addition & 0 deletions conformance/client/standard-unary-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ features:
- STREAM_TYPE_UNARY
# TODO: get client certs working and uncomment this
#supportsTlsClientCerts: true
supportsMessageReceiveLimit: false

0 comments on commit 54f5b5c

Please sign in to comment.