Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: Connect GET requests should not allow a body or content-headers #746

Closed
jhump opened this issue May 28, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@jhump
Copy link
Member

jhump commented May 28, 2024

Since GET requests do not have a body -- request data is instead encoded in the query string -- the client should not send content headers (such as content-length, content-type, content-encoding). Server should not allow a GET requests that does include a non-empty body.

The client in this repo is including content-type headers and the server is not confirming that the body is empty for GET requests.

Found by conformance tests in v1.12.0.

@jhump jhump added the bug Something isn't working label May 28, 2024
@jhump
Copy link
Member Author

jhump commented May 28, 2024

This bug was fixed by #644, and the fix was released in v1.13.0.

@jhump jhump closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant