Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing subpath fallback files #839

Closed
smaye81 opened this issue Sep 27, 2023 · 3 comments
Closed

Investigate removing subpath fallback files #839

smaye81 opened this issue Sep 27, 2023 · 3 comments
Labels
cleanup Cleanup tasks

Comments

@smaye81
Copy link
Member

smaye81 commented Sep 27, 2023

Currently, we have fallback files in packages/connect for consumers that don't support subpath exports (protocol.js, protocol-connect.js, protocol-grpc.js, and protocol-grpc-web.js).

However, these files may not be needed as it is basically supporting Node.js v10 module resolution. Since Node 10 has been EOL for more than two years, we could potentially remove these altogether.

This could potentially break some bundlers, so we'd have to conduct an investigation into whether we could safely remove them.

For further context, see #838 (comment)

@smaye81 smaye81 added the enhancement New feature or request label Sep 27, 2023
@timostamm timostamm added cleanup Cleanup tasks and removed enhancement New feature or request labels Sep 28, 2023
@timostamm
Copy link
Member

We have removed the fallback files in bufbuild/protobuf-es#804.
If this does not cause any issues, we can safely do it here as well.

@timostamm
Copy link
Member

With Parcel and Metro, subpath exports need to be enabled, see https://github.com/bufbuild/protobuf-es/blob/main/MANUAL.md#parcelmetro-fails-to-resolve-imports

@timostamm
Copy link
Member

V2 removes subpath fallbacks for Node10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup tasks
Projects
None yet
Development

No branches or pull requests

2 participants