Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect-fastify plugin upgrade to support v5? #1250

Open
boan-anbo opened this issue Sep 25, 2024 · 2 comments
Open

connect-fastify plugin upgrade to support v5? #1250

boan-anbo opened this issue Sep 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@boan-anbo
Copy link

boan-anbo commented Sep 25, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Support the Fastify v5: https://github.com/fastify/fastify/releases/tag/v5.0.0

Describe the solution you'd like
Can support the Fastify v5 and install the npm plugin package without conflicts. Currently it shows a conflict between 4.22.1 which [email protected] uses.
@boan-anbo boan-anbo added the enhancement New feature or request label Sep 25, 2024
@srikrsna-buf
Copy link
Member

srikrsna-buf commented Sep 25, 2024 •
edited
Loading

Thank you for opening the issue, we definitely want to support v5. Can you send a PR for this?

@timostamm
Copy link
Member

From a quick look at the migration guide, this should be simple.

We can relax the peer dependency constraint to accept v5, and update conformance-fastify.yaml to only run in Node.js v20 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timostamm @boan-anbo @srikrsna-buf