Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testing code #18

Open
masomel opened this issue Jul 15, 2016 · 4 comments
Open

Refactor testing code #18

masomel opened this issue Jul 15, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@masomel
Copy link
Member

masomel commented Jul 15, 2016

There seems to be a lot of repeated code used for testing (e.g. constructing a tree with 3 entries). It might be worth moving these repeated code segments into appropriate functions into a separate module?

cc @c633 @arlolra

@liamsi
Copy link
Member

liamsi commented Aug 3, 2016

As I did some moving around of test code, I could take care of this. Does it make sense to start this soon? I would create a (possibly internal) testutils package where I would the methods that are used in different packages.

@vqhuy
Copy link
Member

vqhuy commented Aug 3, 2016

Sounds good to me!

@liamsi liamsi self-assigned this Aug 12, 2016
@vqhuy vqhuy added this to the 0.2.0 milestone Nov 24, 2016
@vqhuy vqhuy modified the milestones: 0.2.0, 0.2.1 Apr 12, 2017
@vqhuy
Copy link
Member

vqhuy commented Oct 25, 2017

  • Tests in auditlog_test.go should be rewritten and integrated with the directory tests, after our APIs are complete.

  • Rewrite removed consistencychecks_test.go and directory_test.go's tests.

@masomel
Copy link
Member Author

masomel commented Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants