Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment variables with placeholders not working #49

Open
im-pratham opened this issue Feb 21, 2022 · 0 comments
Open

environment variables with placeholders not working #49

im-pratham opened this issue Feb 21, 2022 · 0 comments

Comments

@im-pratham
Copy link

Steps to reproduce -

  1. Lets say you have property like CONTROL_CENTER_STREAMS_SSL_KEYSTORE_PASSWORD with value ${KEYSTORE_PASSWORD}
  2. the dub template command will create admin.properties file with ssl.keystore.passsword=${KEYSTORE_PASSWORD}
  3. The https://github.com/confluentinc/common-docker/blob/master/utility-belt/src/main/java/io/confluent/admin/utils/cli/KafkaReadyCommand.java class only takes properties as key value pair and does no substitution. Hence the docker image fails at step "Checking Kafka Ready".

Background -

I encountered this scenario when I am creating ssl certs using automatic cert provisioning as keystore password is injected as env variable by another system. So I need to just configure the properties using placeholders.

Possible Solutions -

We can add the logic in any of the 3 places mentioned above, 1. dub command (can be good choice), 2. admin.properties.template or in 3. KafkaReadyCommand.java.

Let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant