Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: incorrect path comparison #5062

Closed
sandeepd-nv opened this issue Nov 9, 2023 · 1 comment
Closed

BUG: incorrect path comparison #5062

sandeepd-nv opened this issue Nov 9, 2023 · 1 comment
Labels
source::community catch-all for issues filed by community members stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@sandeepd-nv
Copy link

sandeepd-nv commented Nov 9, 2023

Please do not use string comparison for comparing paths. Consider normalizing the paths before comparison using os.path.normpath or use the Path class etc.

assert base_prefix == dirname(host_prefix)

I am hitting this assert since one of the paths has an extra path separator at the end (otherwise both paths are identical to each other).

@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Nov 9, 2023
@travishathaway travishathaway added type::bug describes erroneous operation, use severity::* to classify the type source::community catch-all for issues filed by community members labels Dec 12, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Dec 12, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Jan 12, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source::community catch-all for issues filed by community members stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🏁 Done
Development

No branches or pull requests

2 participants