-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document recommended method(s) to set environment variables when environments containing a package are activated #5035
Comments
After a bit of source-digging, I see that the Fish shell, among many others, seems to be supported for setting envvars from these JSON files, eliminating the need for activation scripts. I'm feeling really good about this option for our recipe now! |
Hi @mfisher87, Would you recommend us to update this page in any way? |
@travishathaway yes, I think that's a good option (assuming this is a feature Conda wants to advertise). In that case, I feel it would make the most sense to rename the page to "activation automation" or "activation hooks" or something more general. I think it should be structured like:
|
@travishathaway I see you've marked this |
Hi there, thank you for your contribution! This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this issue to remain open please:
NOTE: If this issue was closed prematurely, please leave a comment. Thanks! |
Apologize for my delayed response (oh how the years go by! 😂). Yes, this would be a good issue for you to work on. Let me know if you're still interested, and I can assign it to you. |
Hey Travis, thanks for your response! I understand how it is :) Please assign and I'll take a stab at the docs! |
I help maintain a Conda Forge feedstock, and a user of the package reported problems using the package with Fish. The root cause was our activation scripts not being compatible with their shell, and the docs include a prescient warning:
I'm trying to understand what alternatives are available to me, and I came across some pre-existing discussion which included mention of a mechanism to set envvars using a JSON key-value mapping.
I found the PR that introduced this functionality, but I haven't found any documentation. Is this mechanism deliberately un-documented because it's unsupported? Or is it anticipated that the recipe format will be updated to support this feature to provide a more mature API (#4833)?
After consideration of the above, I'd be happy to help document what it would look like to create this JSON mapping at build-time using a script. I think it would be especially useful to update the Activate Scripts page which I quoted above to point out preferred mechanism(s).
Thanks for your consideration!
PS: While I'm in there, I see the prose on this doc page includes "The installed scripts are recommended to be prefixed by the package name and a separating -.", but both examples use an
_
instead. Which is the true intent of the docs? I'll fix that too :)The text was updated successfully, but these errors were encountered: