Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Implement log flushing #809

Closed
nkaretnikov opened this issue Apr 14, 2024 · 0 comments · Fixed by #808
Closed

[ENH] - Implement log flushing #809

nkaretnikov opened this issue Apr 14, 2024 · 0 comments · Fixed by #808
Assignees
Labels

Comments

@nkaretnikov
Copy link
Contributor

nkaretnikov commented Apr 14, 2024

Feature description

When an env is being built via build_conda_environment, several actions are running. Each of these actions accumulates output into a StringIO object in ActionContext, which is later written to log storage.

Instead, we need to incrementally write to log storage as soon as the output is available, so that users could get visual indication of progress while the job is running.

See #806 (comment).

Value and/or benefit

Improved UX.

Anything else?

  • Moving logged_command to run (in action)
  • Note: make sure log file is not getting overwritten when you repeatedly write to storage (locking)
@nkaretnikov nkaretnikov self-assigned this Apr 14, 2024
@nkaretnikov nkaretnikov moved this from New 🚦 to In Progress 🏗 in conda-store 🐍 Apr 14, 2024
@nkaretnikov nkaretnikov added this to the challenges: Round 2 🚀 milestone Apr 14, 2024
@nkaretnikov nkaretnikov moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Apr 15, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 💪🏾 in conda-store 🐍 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant