Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python 3.13 #58

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10606053513 - please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package pywin32 using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@nicoddemus
Copy link
Member

Build is failing because run_test.py attempts to import win32ui, but fails because win32ui could not be built:

2024-08-29T00:57:26.7362438Z  win32ui: The header 'afxres.h' can not be located.
2024-08-29T00:57:26.7409998Z  win32uiole: The header 'afxres.h' can not be located.

That's a header from MFC, which is part of visual studio.

@xhochy
Copy link
Member

xhochy commented Sep 4, 2024

@conda-forge-admin please restart ci

Azure has worked a bit on their images in the last week. Let's check whether the problem still persists.

@xhochy
Copy link
Member

xhochy commented Sep 4, 2024

Successful build:

2023-09-29T07:54:21.0300423Z Building pywin32 3.11.306.0
2023-09-29T07:54:21.3584299Z -- distutils hack to expose all include & lib dirs
2023-09-29T07:54:21.3586834Z -- orig compiler.include_dirs: ['D:\\bld\\pywin32_1695973767014\\_h_env\\include', 'D:\\bld\\pywin32_1695973767014\\_h_env\\Include']
2023-09-29T07:54:21.3589690Z -- orig compiler.library_dirs: ['D:\\bld\\pywin32_1695973767014\\_h_env\\libs', 'D:\\bld\\pywin32_1695973767014\\_h_env', 'D:\\bld\\pywin32_1695973767014\\_h_env\\PCbuild\\amd64', 'build\\temp.win-amd64-cpython-311\\Release']

Current build:

2024-09-04T15:32:40.0088903Z Building pywin32 3.10.306.0
2024-09-04T15:32:40.0089836Z   from distutils.dep_util import newer_group
2024-09-04T15:32:40.5943253Z -- distutils hack to expose all include & lib dirs
2024-09-04T15:32:40.5945154Z -- orig compiler.include_dirs: ['D:\\bld\\pywin32_1725463818943\\_h_env\\include', 'D:\\bld\\pywin32_1725463818943\\_h_env\\Include']
2024-09-04T15:32:40.5946824Z -- orig compiler.library_dirs: ['D:\\bld\\pywin32_1725463818943\\_h_env\\libs', 'D:\\bld\\pywin32_1725463818943\\_h_env', 'D:\\bld\\pywin32_1725463818943\\_h_env\\PCbuild\\amd64', 'build\\temp.win-amd64-cpython-310\\Release']
2024-09-04T15:32:40.5950784Z -- compiler.library_dirs: ['D:\\bld\\pywin32_1725463818943\\_h_env\\libs', 'D:\\bld\\pywin32_1725463818943\\_h_env', 'D:\\bld\\pywin32_1725463818943\\_h_env\\PCbuild\\amd64', 'build\\temp.win-amd64-cpython-310\\Release', 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.29.30133\\lib\\x64', 'C:\\Program Files (x86)\\Windows Kits\\NETFXSDK\\4.8\\lib\\um\\x64', 'C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.22621.0\\ucrt\\x64', 'C:\\Program Files (x86)\\Windows Kits\\10\\\\lib\\10.0.22621.0\\\\um\\x64', 'D:\\bld\\pywin32_1725463818943\\_h_env\\Library\\lib', 'D:\\bld\\pywin32_1725463818943\\_h_env\\Library\\lib']
2024-09-04T15:32:40.5952503Z -- ATLMFC paths likely missing (Required for win32ui)

@xhochy
Copy link
Member

xhochy commented Sep 4, 2024

Upstream has a lot of code that fixes the build with Python 3.13 and removes the usage of distutils. Cherry-picking single commits doesn't seem worthwhile, so we will need to wait for a release.

@isuruf
Copy link
Member

isuruf commented Sep 20, 2024

See conda-forge/conda-smithy#2062

@xhochy xhochy force-pushed the rebuild-python313-0-1_h7658d0 branch from f534499 to a3017e1 Compare September 21, 2024 06:42
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Sep 25, 2024

There are several instances in the code of PyEval_CallObject which all would need replacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants