Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HDF5 ecosystem to 1.8.18 #71

Closed
30 of 35 tasks
qwhelan opened this issue Jun 2, 2017 · 5 comments
Closed
30 of 35 tasks

Update HDF5 ecosystem to 1.8.18 #71

qwhelan opened this issue Jun 2, 2017 · 5 comments

Comments

@qwhelan
Copy link
Contributor

qwhelan commented Jun 2, 2017

After merging #68, I realized that almost all conda-forge packages have pinned their recipes to 1.8.17|1.8.17.*. As hdf5 is cautious and checks that version numbers are the same for headers and shared objects, we'll need to update the pinned versions to allow a user to use 1.8.18.

I identified all conda-forge packages using hdf5 by checking out https://github.com/conda-forge/feedstocks, running git submodule init && git submodule update, and then executing the following:

grep hdf5 * -R | awk -F/ '{print $1}' | sort | uniq > hdf5.txt

I will be creating PRs for each library below and checking them off as they get merged:

@gillins
Copy link
Contributor

gillins commented Jun 2, 2017

II don't know much about it, but I thought updating https://github.com/conda-forge/conda-forge.github.io/blob/master/scripts/pin_the_slow_way.py would achieve the same result in a more automated fashion. cc @ocefpaf @jakirkham

@jakirkham
Copy link
Member

That would be the place to start. Yes the bot should do this, but it is broken of late.

Still we should first send a PR to that script and only then PR the feedstocks after the pinning change has been accepted.

@qwhelan
Copy link
Contributor Author

qwhelan commented Jun 2, 2017

@gillins Thanks for pointing that out - definitely looked for something like this but didn't see any traces of it in most feedstocks I sampled.

Handling the upstream pin in conda-forge/conda-forge.github.io#394

@jakirkham
Copy link
Member

Thank you for doing that @qwhelan and putting in the time to make all these PRs. It's definitely appreciated.

@jakirkham
Copy link
Member

Are we good to close this out? I think everything either got rebuilt with 1.8.18, got rebuilt with 1.10.1, or is simply lagging behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants