Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'unpack' when initial_content_binary is an archive file #116

Open
grenzr opened this issue Jan 14, 2019 · 2 comments
Open

Support 'unpack' when initial_content_binary is an archive file #116

grenzr opened this issue Jan 14, 2019 · 2 comments

Comments

@grenzr
Copy link

grenzr commented Jan 14, 2019

Hi all, we have an s3 input as follows:

- name: bbl-state
  type: s3
  source:
    <<: *minio-s3
    bucket: bosh-state-files
    regexp: bbl-state-(.*).tgz
    initial_path: /bbl-state-0.0.0.tgz
    initial_content_binary: ((bbl-state-init-tgz))

And when the resource is used we do so as follows:

    - get: bbl-state
      params:
        unpack: true

However, I have just noticed that the first execution does not unpack the initial_content_binary. As I can see in the code, it attempts to extract before placing the initial binary.

Would you accept a PR to resolve this, or was this by design for some reason?

@vito
Copy link
Member

vito commented Jan 15, 2019

Probably an oversight, PR welcome! Definitely seems like it should unpack since the initial content is meant to simulate an initial version.

@grenzr
Copy link
Author

grenzr commented Jan 18, 2019

Thanks @vito I'm working on it now .. PR on the way soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants