[feature] Git.coordinates_to_conandata() is missing the repository argument.

[Adnn]

What is your suggestion?

As discussed in previous issues, a repository argument has been added to both Git.get_commit() and Git.get_url_and_commit().
It looks like an oversight that it is not present on Git.coordinates_to_conandata().

Have you read the CONTRIBUTING guide?

• I've read the CONTRIBUTING guide

[memsharded]

Hi @Adnn

Thanks for the suggestion.

This looks like a valid case, and it looks pretty trivial to implement.
Do you think there is any downside or possible risk? Anything that should be taken into account if storing the repo commit instead of the folder one? Should anything change in the stored data in the conandata.yml? I think not, but just in case.

[Adnn]

Hi @memsharded , and thank you for your answer.

As far as I understand the situation, repository=True | repository=False are really orthgonal use-cases (1st for hosting a single conanfile in a subfolder of a repo, second for hosting distinct conanfiles in a single repo).
I suppose coordinates_to_conandata() is implemented under the hood in term of get_url_and_commit(), so I think it was a simple oversight, and forwarding the parameter (with the same default value of False) should not cause anyone any surprises.

[Adnn]

I will actually try to implement this trivial forward, pay a tiny bit of my due.