-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package] open62541/1.4.6: Unable to build package with option discovery=multicast (pro-mdnsd) #26471
Comments
@steinerthomas I don't remember the reason I deleted this. I can't think of a reason from the top of my hat. If you fix this maybe add a test using option |
Improvement in open62541 for future versions? open62541/open62541#7060 |
For a better understanding of this case:
The previous patch can be re-added in order to use mdnsd from Conan as external dependency. In case it was a vendorized dependency (whole copy of the project in deps/ instead of gitmodules) would not be a problem and I would not suggest splitting by using Conan (that's not the case). The same previous patch is adapting some dependency variables like OPENSSL_LIBRARIES to OpenSSL_LIBRARIES. Those variables can now be mitigated by using the CMakeDeps property cmake_additional_variables_prefixes, and it's already in the recipe, see MBEDTLS fix. @steinerthomas I see you are still using Conan 1.x and only few CMakeDeps properties are available, not including Still, thank you for reporting this case and taking your time by asking the upstream for an alternative regarding usage. |
Thank you for improving my pr and describing the problem in detail! I'm going to move to conan2 soon. Bumping all dependecies to conan1-frozen and cleanup manual patches in recipes was the first step for the migration. |
Description
With PR #20892 (commit 606f757) the patches for finding cmake deps where removed and no longer maintained for new versions.
This change prevents building open62541 with option
discovery=multicast
:@Kischy what was the reason to remove these patches? Am I missing something?
Our currently forked version has patches for fixing the mdnsd dependecy applied.
Package and Environment Details
Conan profile
[settings]
os=Linux
os_build=Linux
arch=x86_64
arch_build=x86_64
compiler=gcc
compiler.version=12
compiler.libcxx=libstdc++
build_type=Release
[options]
[conf]
[build_requires]
[env]
Steps to reproduce
conan create recipes/open62541/all open62541/1.4.6@ -tf None -o discovery=multicast --build=missing
Logs
Click to expand log
The text was updated successfully, but these errors were encountered: