Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

au: Add new version #26181

Closed
AbrilRBS opened this issue Dec 13, 2024 · 1 comment · Fixed by #26462
Closed

au: Add new version #26181

AbrilRBS opened this issue Dec 13, 2024 · 1 comment · Fixed by #26462

Comments

@AbrilRBS
Copy link
Member

AbrilRBS commented Dec 13, 2024

would either of you be interested in updating the recipe to Au 0.4.0? It was just released today, and it should reduce the need for all the CMake patching in the 0.3.5 recipe!

(I could also do the PR myself, but I've never used conan, so I thought it might be better to let somebody who knows what they're doing give it a shot.)

Originally posted by @chiphogg in #25447 (comment)

chiphogg added a commit to chiphogg/conan-center-index that referenced this issue Dec 15, 2024
Unfortunately, we discovered a small breakage in 0.4.0: we forgot to add
one of the headers to `CMakeLists.txt`.  I added a patch which fixes the
build.

Along the way, I also used Au's new options to avoid enabling tests and
bringing in the GTest dependency.  This means we don't need to keep
using a version of the existing patch file for 0.3.5.

I also updated the test file to be more idiomatic.

Fixes conan-io#26181.
chiphogg added a commit to chiphogg/conan-center-index that referenced this issue Jan 24, 2025
Unfortunately, we discovered a small breakage in 0.4.0: we forgot to add
one of the headers to `CMakeLists.txt`.  I added a patch which fixes the
build for 0.4.0.  Version 0.4.1 does not use this patch.

Along the way, I also used Au's new options to avoid enabling tests and
bringing in the GTest dependency.  This means we don't need to keep
using a version of the existing patch file for 0.3.5.

I also updated the test file to be more idiomatic.

I tested these installations with the following commands:

```sh
cd recipes/au
conan create all/conanfile.py --version=0.4.0
conan create all/conanfile.py --version=0.4.1
```

Fixes conan-io#26181.
@chiphogg
Copy link
Contributor

See: #26462. I learned how to update a conan recipe! 🙂

jcar87 pushed a commit that referenced this issue Feb 11, 2025
* Add version 0.4.0, 0.4.1 of Au to conan

Unfortunately, we discovered a small breakage in 0.4.0: we forgot to add
one of the headers to `CMakeLists.txt`.  I added a patch which fixes the
build for 0.4.0.  Version 0.4.1 does not use this patch.

Along the way, I also used Au's new options to avoid enabling tests and
bringing in the GTest dependency.  This means we don't need to keep
using a version of the existing patch file for 0.3.5.

I also updated the test file to be more idiomatic.

I tested these installations with the following commands:

```sh
cd recipes/au
conan create all/conanfile.py --version=0.4.0
conan create all/conanfile.py --version=0.4.1
```

Fixes #26181.

* Put most recent recipes first

This seems more commonly done.

* Remove 0.4.0 and patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants