Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-downs don't show all options when selecting one due to text filtering #315

Open
MaxGhenis opened this issue Aug 6, 2020 · 1 comment

Comments

@MaxGhenis
Copy link
Contributor

For example, OG-USA has a few true/false drop-downs, which look like this initially:
image

But when selecting one, the drop-down no longer shows all the options, since it text-matches:
image

You can see other options by deleting the text in the text box, but I think a normal drop-down that shows all values would be more intuitive (maybe unless there are too many options to show, but I haven't seen that from any models yet).

@hdoupe
Copy link
Contributor

hdoupe commented Aug 7, 2020

@MaxGhenis We swapped to using the datalist HTML element from a dropdown like you are suggesting. The reason is that we need to support inputs like True,False,*,*,True in Tax-Brain so users can specify values for future years. The datalist gives the best of both worlds: you can select values from a dropdown while being able to type in your own value. However, it also has some disadvantages like what you've pointed out.

I'd love to replace this with something better. For example, the array input fields that we discussed in #311 could be extended to replace the wildcard syntax. However, the logic for getting this right is pretty complicated. This is my motivation for writing ParamTools.js which would expose richer ParamTools functionality on the client side and make it easier to support complicated inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants