Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests don't exceed rate limit, use mock responses #21

Open
compscidr opened this issue Oct 9, 2024 · 0 comments
Open

Ensure tests don't exceed rate limit, use mock responses #21

compscidr opened this issue Oct 9, 2024 · 0 comments

Comments

@compscidr
Copy link
Owner

There are two issues here, one is that we are making real requests to scholar (which we probably still want some of, but we also want to carefully avoid throttling across multiple test runs). This may mean some local persistence of the request rate or something that can span multiple runs of the program.

The second issue is that we should probably have reproduced responses used to mock the response from the actual server side of things for the majority of tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant