Skip to content

Commit cfbecfd

Browse files
committed
Emscripten finds Development.Embed and not Python::Python
1 parent b6444e3 commit cfbecfd

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.github/workflows/main.yml

+1
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ jobs:
196196
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
197197
..
198198
EMCC_CFLAGS='-sERROR_ON_UNDEFINED_SYMBOLS=0' emmake make -j5
199+
199200
- name: Setup tmate session
200201
if: ${{ failure() && runner.debug }}
201202
uses: mxschmitt/action-tmate@v3

CMakeLists.txt

+8-1
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,14 @@ macro(xeus_cpp_create_target target_name linkage output_name)
314314
set(XEUS_CPP_XEUS_TARGET xeus-static)
315315
endif ()
316316

317-
target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse xtl Python::Python)
317+
target_link_libraries(${target_name} PUBLIC ${XEUS_CPP_XEUS_TARGET} clangCppInterOp pugixml argparse::argparse xtl)
318+
if (EMSCRIPTEN)
319+
# For some reason emscripten cannot find Python::Python.
320+
target_link_libraries(${target_name} PUBLIC Development.Embed)
321+
else()
322+
target_link_libraries(${target_name} PUBLIC Python::Python)
323+
endif();
324+
318325
if (WIN32 OR CYGWIN)
319326
#
320327
elseif (APPLE)

0 commit comments

Comments
 (0)