Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-ECLA : GitHub/GitLab Contributor remain authorized after remove from approval list #3996

Closed
thakurveerendras opened this issue Jun 23, 2023 · 7 comments
Closed

Auto-ECLA : GitHub/GitLab Contributor remain authorized after remove from approval list #3996

thakurveerendras opened this issue Jun 23, 2023 · 7 comments
Assignees
@umeshlumbhani247
Labels
bug Something isn't working

Comments

@thakurveerendras
Copy link
Contributor

Summary

Auto-ECLA : Contributor remain authorized after remove from approval list

Steps

  1. Login CD portal
  2. Search & open project SUN
  3. Enabled Auto-ecla options (if not enabled)
  4. Add GitLab user : thakurveerendras1 under approval list
  5. See-User added under contributor list with authorized status
  6. Now remove user from approval list

Actual behavior

User status is remain authorized

Expected behavior

User status should be updated to Not Authorized

Screenshots

image
@thakurveerendras thakurveerendras added the bug Something isn't working label Jun 23, 2023
@thakurveerendras thakurveerendras mentioned this issue Jun 23, 2023
Closed
umeshlumbhani247 added a commit that referenced this issue Jun 27, 2023
@umeshlumbhani247
[#3996] added github and gitlab username to signature
a79c68d 
Signed-off-by: Umesh Lumbhani <[email protected]>
@umeshlumbhani247
Copy link
Collaborator

umeshlumbhani247 commented Jun 27, 2023 •
edited
Loading

@thakurveerendras
I have raised below PR for fixing this bug.
#4000

nickmango added a commit that referenced this issue Jun 27, 2023
@nickmango
Merge pull request #4000 from communitybridge/bug/gitlab_signature_in…
fdc2c0b 
…validate_issue

[#3996] added github and gitlab username to signature
@thakurveerendras
Copy link
Contributor Author

Tested issue on dev site & found that it is fixed as expected, Now Not Authorized appears after remove GitLab user from approval list
Refer video clip :
3996.webm

@thakurveerendras
Copy link
Contributor Author

Tested issue on production & found that it is fixed as expected, So making issue status QA-Done

@thakurveerendras
Copy link
Contributor Author

Tested the issue & found that it is reproducible with the below GitLab user

Refer GitLab User :

  1. thakuveerendras
  2. thakuveerendras1
  3. vthakurgitlab
  4. vthakur.lflegal

Refer PR: https://gitlab.com/childearthgroup/project1/-/merge_requests/5

@thakurveerendras thakurveerendras changed the title Auto-ECLA : GitLab Contributor remain authorized after remove from approval list Auto-ECLA : GitHub/GitLab Contributor remain authorized after remove from approval list Jul 19, 2023
@umeshlumbhani247
Copy link
Collaborator

@thakurveerendras @nickmango
I have resolved this issue, Please find PR: 4053
CC: @mlehotskylf

@thakurveerendras
Copy link
Contributor Author

Failed case on this issue will be covered on the issue #4001, So making this issue status QA-Done

@mlehotskylf
Copy link
Contributor

This is resolved, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umeshlumbhani247 umeshlumbhani247

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mlehotskylf @thakurveerendras @umeshlumbhani247