Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: akveo/nebular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: commudle/nebular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 15 files changed
  • 2 contributors

Commits on Oct 23, 2022

  1. chore: fix bootstrap versions

    @Ashwin-op
    Ashwin-op committed Oct 23, 2022

    Verified

    This commit was signed with the committer’s verified signature.
    Ashwin-op Ashwin B S
    GPG key ID: 9FBB45E1F957067C
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6b4611f View commit details

Commits on Oct 24, 2022

  1. chore: upgrade to angular 14

    @Ashwin-op
    Ashwin-op committed Oct 24, 2022

    Verified

    This commit was signed with the committer’s verified signature.
    Ashwin-op Ashwin B S
    GPG key ID: 9FBB45E1F957067C
    Verified
    Learn about vigilant mode
    Copy the full SHA
    bc85bbc View commit details

  2. chore: fix tests

    @Ashwin-op
    Ashwin-op committed Oct 24, 2022

    Verified

    This commit was signed with the committer’s verified signature.
    Ashwin-op Ashwin B S
    GPG key ID: 9FBB45E1F957067C
    Verified
    Learn about vigilant mode
    Copy the full SHA
    2106dc4 View commit details

Commits on Oct 26, 2022

  1. Merge pull request #1 from Ashwin-op/master 

    Upgrade to Angular 14
    @arpansac
    arpansac authored Oct 26, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c960e5d View commit details

  2. setup npm package

    @arpansac
    arpansac committed Oct 26, 2022
    Copy the full SHA
    d2e08fc View commit details
3 changes: 1 addition & 2 deletions e2e/sidebar-two.e2e-spec.ts
View file
Original file line number Diff line number Diff line change
@@ -7,13 +7,12 @@
import { browser, element, by } from 'protractor';

describe('nb-sidebar-two', () => {

beforeEach((done) => {
browser.get('#/sidebar/sidebar-two-test.component').then(() => done());
});

it('should render left non-fixed sidebar height minus header', () => {
Promise.all<any, any, any>([
Promise.all<any>([
element(by.css('nb-layout')).getSize(),
element(by.css('nb-layout-header')).getSize(),
element.all(by.css('nb-sidebar')).get(0).getSize(),
Loading