Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF-8 BOM from source files #1213

Open
lassoan opened this issue Aug 15, 2024 · 1 comment
Open

Remove UTF-8 BOM from source files #1213

lassoan opened this issue Aug 15, 2024 · 1 comment

Comments

@lassoan
Copy link
Member

lassoan commented Aug 15, 2024

These source files start with UTF-8 BOM, which causes build failure on Korean computers:

CTK\Libs\DICOM\Core\ctkDICOMRetrieve.cpp
CTK\Libs\DICOM\Widgets\ctkDICOMJobListWidget.h CTK\Libs\DICOM\Widgets\ctkDICOMPatientItemWidget.h CTK\Libs\DICOM\Widgets\ctkDICOMSeriesItemWidget.h CTK\Libs\DICOM\Widgets\ctkDICOMStudyItemWidget.h CTK\Libs\DICOM\Widgets\ctkDICOMVisualBrowserWidget.h

The build scripts should be improved to not be sensitive to the presence of a UTF-8 BOM, but for consistency, we should not just start using BOM for some source files. For now, the easiest is to keep using ASCII in all CTK source files. If there is a good reason to change this in the future then it should be changed for all source files.

@Punzo
Copy link
Contributor

Punzo commented Aug 16, 2024

Done in #1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants