Skip to content

Commit 3d42399

Browse files
authored
Merge pull request #6237 from benz0li/finalise-dev-containers-c7b679a
Finalise Dev Containers
2 parents c7b679a + 80dde68 commit 3d42399

File tree

5 files changed

+9
-14
lines changed

5 files changed

+9
-14
lines changed

.devcontainer/.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
!/assets/cradles/
55
!/assets/cradles/cabal/
66
!/assets/cradles/stack/
7-
!/assets/screenshots/
7+
!/backups/
88
!/bind-mounts/
99
!/conf/
1010
!/conf/etc/
@@ -17,7 +17,6 @@
1717

1818
!/assets/cradles/cabal/hie.yaml
1919
!/assets/cradles/stack/hie.yaml
20-
!/assets/screenshots/manageHLS.png
2120
!/conf/etc/stack/config.yaml
2221
!/ghc-*/devcontainer.json
2322
!/scripts/usr/local/bin/*.sh

.devcontainer/GHC.Dockerfile

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ RUN sysArch="$(uname -m)" \
3636
## Ensure that common CA certificates
3737
## and OpenSSL libraries are up to date
3838
&& apk upgrade --no-cache ca-certificates openssl-dev \
39-
## Install yamllint
40-
&& apk add --no-cache yamllint \
4139
## Install pip
4240
&& apk add --no-cache py3-pip \
4341
## Install terminal multiplexers
4442
&& apk add --no-cache screen tmux \
43+
## Install yamllint
44+
&& apk add --no-cache yamllint \
4545
## Install hadolint
4646
&& case "$sysArch" in \
4747
x86_64) tarArch="x86_64" ;; \
@@ -53,11 +53,7 @@ RUN sysArch="$(uname -m)" \
5353
&& downloadUrl="$(echo "$apiResponse" | grep -e \
5454
"browser_download_url.*Linux-$tarArch\"" | cut -d : -f 2,3 | tr -d \")" \
5555
&& echo "$downloadUrl" | xargs curl -sSLo /usr/local/bin/hadolint \
56-
&& chmod 755 /usr/local/bin/hadolint \
57-
## Create folders in root directory
58-
&& mkdir -p /root/.local/bin \
59-
## Create folders in skeleton directory
60-
&& mkdir -p /etc/skel/.local/bin
56+
&& chmod 755 /usr/local/bin/hadolint
6157

6258
## Update environment
6359
ARG USE_ZSH_FOR_ROOT

.devcontainer/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Dev Containers
22

3-
See [haskellstack.org](https://docs.haskellstack.org): Stack's code (advanced)
4-
\> Maintainers \> Dev Containers or
5-
[../doc/maintainers/devcontainers.md](../doc/maintainers/devcontainers.md)
6-
for more information.
3+
For further information, see
4+
[haskellstack.org](https://docs.haskellstack.org): Stack's code (advanced) \>
5+
Contributors \> Dev Containers or
6+
[../doc/dev_containers.md](../doc/dev_containers.md).
77

88
## License
99

.devcontainer/backups/.keep

Whitespace-only changes.

.devcontainer/scripts/usr/local/bin/onCreateCommand.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ if ! grep -q "cabal's bin" "$HOME/.zshrc"; then
3838
fi
3939

4040
# Enable Oh My Zsh plugins
41-
sed -i "s/plugins=(git)/plugins=(cabal git pip stack screen tmux vscode)/g" "$HOME/.zshrc"
41+
sed -i "s/plugins=(git)/plugins=(cabal git pip screen stack tmux vscode)/g" "$HOME/.zshrc"
4242

4343
# Remove old .zcompdump files
4444
rm -f "$HOME"/.zcompdump*

0 commit comments

Comments
 (0)