Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena webrtc streamer #34226

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jakethesnake420
Copy link
Contributor

Not expecting a merge, just showing this working demo of how webrtc could be used with connect in the future.

@jakethesnake420 jakethesnake420 marked this pull request as draft December 13, 2024 03:44
@jakethesnake420
Copy link
Contributor Author

Recording.2024-12-12.215222.mp4

@jakethesnake420
Copy link
Contributor Author

Recording.2024-12-12.220040.mp4

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 23, 2024
@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Dec 23, 2024

Cool! How well does this work over cell? Ultimately, I'd like to replace snapshot in connect with a live stream.

@jakethesnake420
Copy link
Contributor Author

jakethesnake420 commented Dec 23, 2024

Cool! How well does this work over cell? Ultimately, I'd like to replace snapshot in connect with a live stream.

It works reliably well. I created my own TURN server using coturn so it relays through that when using mobile data. You obviously need a decent cell connection for live streaming. Even with a bad connection it will still send some frames. WebRTC is robust to connection interruptions but since its using athena, if the websocket connection times out, it will set the end_event and reset everything.

@jakethesnake420
Copy link
Contributor Author

@adeebshihadeh The video I posted was using a turn server over mobile hotspot, not the local network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants