cabana: add support to fetch preserved routes

[deanlee]

Thanks to @pbassut for the contribution in PR #34105. The original implementation worked, but the UI and logic were a bit more complex than needed, and continuing to spend time fixing bugs based on it doesn’t seem worth it. this PR simplified the approach, keeping the functionality while reducing the overall complexity. It should be sufficient to implement this feature.

[pbassut]

So, does this mean we can trash the original PR?

[pbassut]

Just a heads up, this is not the same feature I had originally implemented. The preserved selector is now in a combobox that people will only notice if they open it in the first place.

And have it in a combobox with the value set to -1 seems like a hack. If we were to add other options like "routes with OP engagement", "routes with faults" etc, keeping adding items in there wouldn't scale. The combobox is serving multiple purposes.

In addition, and more importantly, opening up a PR with the same feature that another PR already have it is not a cool move. I'm happy to do all the back and forth necessary to bring people up to speed and have them contribute in the long run. What happened here makes people not contribute if their work is going to the trash anyway.

I know it sounds like you're trying to get your commit counts up but there are better ways to get there while still maintaining a healthy community.

Finally, I'll close the PR now since no one responded.

[deanlee]

Thank you for your feedback. I appreciate the time and effort you've put into implementing this feature.

That said, I’d like to clarify my reasoning. The RouteDialog feature in Cabana is not a core component, and we don’t need a fully developed route list browser with features like “routes with OP engagement” or “routes with faults.” The goal here is simplicity—a basic list that gets the job done. Adding unnecessary complexity would introduce maintenance challenges without adding much value.

Over the past few days, I carefully reviewed your PR and provided suggestions for improvement. My decision to propose a simpler version was driven by the fact that the current implementation introduced new bugs. Resolving those issues, along with the added complexity, would create unnecessary overhead for the project, which, in my opinion, outweighs any potential benefits.

I’m committed to maintaining a healthy and productive development environment, and my focus is always on the long-term stability of the project.

As an external contributor, like yourself, I deeply value everyone’s contributions. If my PR has caused any frustration, please know that my intention was never to diminish anyone’s work, but rather to help ensure the long-term stability and health of the project.