Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HKG: unable to engage with pause/resume button with stock cruise control #34047

Open
sshane opened this issue Nov 18, 2024 · 1 comment
Open

HKG: unable to engage with pause/resume button with stock cruise control #34047

sshane opened this issue Nov 18, 2024 · 1 comment
Labels
bug car vehicle-specific hyundai
Milestone
0.9.8

Comments

@sshane
Copy link
Contributor

sshane commented Nov 18, 2024 •
edited
Loading

With the opendbc refactor this logic is now in openpilot, so we need to either:

  • detect if car has pause/resume button and don't add cancel button
  • or allow cancel press to enable for Hyundai like we used to
@sshane sshane added bug car vehicle-specific hyundai labels Nov 18, 2024
@sshane sshane transferred this issue from commaai/opendbc Nov 18, 2024
@sshane sshane added this to the 0.9.8 milestone Nov 18, 2024
@sshane sshane mentioned this issue Nov 18, 2024
Merged
@sunnyhaibin sunnyhaibin mentioned this issue Nov 19, 2024
Open
@royjr
Copy link
Contributor

royjr commented Dec 8, 2024

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug car vehicle-specific hyundai
Projects
None yet
Milestone
0.9.8
Development

No branches or pull requests
2 participants
@royjr @sshane