Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OP w/ brakeHold active #34032

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enable OP w/ brakeHold active #34032

wants to merge 2 commits into from

Conversation

jsegill
Copy link

@jsegill jsegill commented Nov 15, 2024

Following EventName.resumeRequired "Press Resume to Exit Standstill"

@jsegill
Attempting to resume OP w/ brakeHold Active
aa45bbf 
Tried changing logic within events.py for brakeHold
@jsegill
Enable OP w/ brakeHold active
94e7c24 
Following EventName.resumeRequired "Press Resume to Exit Standstill"
@sunnyhaibin
Copy link
Contributor

sunnyhaibin commented Nov 17, 2024 •
edited
Loading

Are you sure this works for all car brands? Hyundai does not allow you to engage SCC if brake hold is active.

This is also not the correct way to introduce allowing brake hold to transition openpilot to enabled:

  • No longer disables openpilot when entering brake hold active
  • Fails the unit tests as it triggers panda safety violations

@jsegill
Copy link
Author

jsegill commented Nov 24, 2024 •
edited
Loading

I believe folks at Comma are testing this on different car models. I believe after that batch of testing, recommendations will be made on how to proceed. You're definitely right, this will need further changes in structure to work.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Dec 9, 2024
@adeebshihadeh adeebshihadeh reopened this Dec 16, 2024
@github-actions github-actions bot removed the stale label Dec 17, 2024
@adeebshihadeh adeebshihadeh marked this pull request as draft December 18, 2024 22:12
@github-actions GitHub Actions
Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsegill @sunnyhaibin @adeebshihadeh