Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: run model replay on tinygrad bumps #34014

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

adeebshihadeh
Copy link
Contributor

No description provided.

@adeebshihadeh
Copy link
Contributor Author

adeebshihadeh commented Nov 13, 2024

@maxime-desroches the diff doesn't seem to work for submodules. Can you finish this up?

@maxime-desroches
Copy link
Contributor

Ah, the diff we gets returns tinygrad_repo without the /, which won't match with our diffpath tinygrad_repo/

@adeebshihadeh
Copy link
Contributor Author

Oh that's fine, let's just remove that slash.

@maxime-desroches maxime-desroches merged commit 3fffd6c into master Nov 13, 2024
18 of 19 checks passed
@maxime-desroches maxime-desroches deleted the model-replay-diff branch November 13, 2024 20:03
ssysm pushed a commit to MOTIF-lab/openpilot that referenced this pull request Feb 13, 2025
* jenkins: run model replay on tinygrad bumps

* bump

* /

* fix

---------

Co-authored-by: Maxime Desroches <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants