Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlsd: resume from stop doesn't work with stock long #33850

Closed
sshane opened this issue Oct 22, 2024 · 9 comments
Closed

controlsd: resume from stop doesn't work with stock long #33850

sshane opened this issue Oct 22, 2024 · 9 comments
Labels
bug controls controls/planner related
Milestone

Comments

@sshane
Copy link
Contributor

sshane commented Oct 22, 2024

No description provided.

@adeebshihadeh
Copy link
Contributor

Doesn't matter since we're going to use openpilot long

@sshane
Copy link
Contributor Author

sshane commented Oct 22, 2024

Right, but this looks like a regression for all the stock long cars (cruiseControl.resume never activates). Will re-visit after Ford.

@sshane sshane removed the ford label Oct 22, 2024
@sshane sshane transferred this issue from commaai/opendbc Oct 22, 2024
@sshane sshane changed the title Ford: resume from stop doesn't work with stock long controlsd: resume from stop doesn't work with stock long Oct 22, 2024
@sshane sshane added the controls controls/planner related label Oct 22, 2024
@BBBmau
Copy link
Contributor

BBBmau commented Oct 27, 2024

I'm experiencing this also except it's on experimental. I have a '23 Sonata with device on master with commit af73d60 i believe.

Edit: The actual commit on the device is 6175106

@sshane
Copy link
Contributor Author

sshane commented Oct 28, 2024

Can you post a route where this happens?

@sshane sshane added this to the 0.9.8 milestone Oct 28, 2024
@BBBmau
Copy link
Contributor

BBBmau commented Oct 28, 2024

@sshane
Edit: correct route is

https://connect.comma.ai/9a31d18cd1a79c69/00000177--035b67fbc9/160/164

9a31d18cd1a79c69/00000177--035b67fbc9/2

@sshane
Copy link
Contributor Author

sshane commented Oct 28, 2024

The model in experimental mode failing to resume at traffic lights is different than controlsd setting the carControl.cruiseControl.resume signal based on the planner/lead BTW, that's what this issue is for

@BBBmau
Copy link
Contributor

BBBmau commented Oct 28, 2024

The model in experimental mode failing to resume at traffic lights is different than controlsd setting the carControl.cruiseControl.resume signal based on the planner/lead BTW, that's what this issue is for

yeah the route is wrong, I'll be providing the route with the actual issue later today. Sorry for the confusion.

@BBBmau
Copy link
Contributor

BBBmau commented Oct 29, 2024

@sshane looking to see what needs to be changed. A bit interesting how on resume it goes to the saved speed but is quickly reverted to be 65

image

@sshane
Copy link
Contributor Author

sshane commented Jan 15, 2025

This works on a recent route, not sure if this was a real issue. Closing

image

@sshane sshane closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug controls controls/planner related
Projects
None yet
Development

No branches or pull requests

3 participants