-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controlsd: resume from stop doesn't work with stock long #33850
Comments
Doesn't matter since we're going to use openpilot long |
Right, but this looks like a regression for all the stock long cars (cruiseControl.resume never activates). Will re-visit after Ford. |
Can you post a route where this happens? |
@sshane https://connect.comma.ai/9a31d18cd1a79c69/00000177--035b67fbc9/160/164 9a31d18cd1a79c69/00000177--035b67fbc9/2 |
The model in experimental mode failing to resume at traffic lights is different than controlsd setting the carControl.cruiseControl.resume signal based on the planner/lead BTW, that's what this issue is for |
yeah the route is wrong, I'll be providing the route with the actual issue later today. Sorry for the confusion. |
@sshane looking to see what needs to be changed. A bit interesting how on resume it goes to the saved speed but is quickly reverted to be 65 |
No description provided.
The text was updated successfully, but these errors were encountered: