Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ford FW responses sometimes skip a consecutive frame #1794

Open
blue-genie opened this issue Feb 22, 2025 · 4 comments
Open

Ford FW responses sometimes skip a consecutive frame #1794

blue-genie opened this issue Feb 22, 2025 · 4 comments

Comments

@blue-genie
Copy link
Contributor

blue-genie commented Feb 22, 2025

Route: e36b272d5679115f/0000030f--340e67d898

Opened a new issue since the old one had some other changes as well, now I'm back to master + dashcam removal, see below the git diffs

More than 6 minutes long - Dashcam with unrecognized car

git diff output:

comma@comma-e11dd515:/data/openpilot$ git diff
diff --git a/opendbc_repo b/opendbc_repo
--- a/opendbc_repo
+++ b/opendbc_repo
@@ -1 +1 @@
-Subproject commit 4185f81635edab3e943a881edde7e1a03d43ec9c
+Subproject commit 4185f81635edab3e943a881edde7e1a03d43ec9c-dirty
comma@comma-e11dd515:/data/openpilot/opendbc_repo$ git diff
diff --git a/opendbc/car/ford/interface.py b/opendbc/car/ford/interface.py
index 26a18ea..1b22341 100644
--- a/opendbc/car/ford/interface.py
+++ b/opendbc/car/ford/interface.py
@@ -20,7 +20,7 @@ class CarInterface(CarInterfaceBase):
   @staticmethod
   def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, experimental_long, docs) -> structs.CarParams:
     ret.brand = "ford"
-    ret.dashcamOnly = bool(ret.flags & FordFlags.CANFD)
+#    ret.dashcamOnly = bool(ret.flags & FordFlags.CANFD)

     ret.radarUnavailable = Bus.radar not in DBC[candidate]
     ret.steerControlType = structs.CarParams.SteerControlType.angle

To fix it, while driving I just rebooted the device. The next route e36b272d5679115f/00000310--6760d21c98 did a good fingerprinting.

@adeebshihadeh
Copy link
Contributor

I don't understand this issue?

@sshane
Copy link
Contributor

sshane commented Feb 23, 2025

Try this branch for a few days: https://github.com/commaai/opendbc/tree/ford-queries

The query for the EPS didn't come back the second time, unclear why the panda or gateway is dropping single CAN messages silently (we see them on the other buses, but not the one we requested it on).

Adeeb, this is likely the same issue you posted about in the Bronco

@sshane sshane changed the title Ford Q4 fingerprinting issue - take 2 Ford FW queries sometimes skip a consecutive frame Feb 23, 2025
@sshane sshane changed the title Ford FW queries sometimes skip a consecutive frame Ford FW responses sometimes skip a consecutive frame Feb 23, 2025
@sshane sshane added the bug label Feb 23, 2025
@blue-genie
Copy link
Contributor Author

Any supported way to update the submodule on the device without a branch in openpilot and using the branch switcher?

Just trying to stay away from dirty git.

I know how to do it via ssh & git if this is the request.

@blue-genie
Copy link
Contributor Author

blue-genie commented Feb 23, 2025

route: e36b272d5679115f/00000319--0e9ee82ed2 - using the ford-queries branch.
Rebooted, and route 31a worked fine.

Steps taken:

  1. Disable updates.
  2. git checkout origin/ford-queries in opendbc_repo
  3. reboot
++pwd
/data/openpilot
++ git diff
diff --git a/opendbc_repo b/opendbc_repo
index 4ffe21a51..0ebf0fbe4 160000
--- a/opendbc_repo
+++ b/opendbc_repo
@@ -1 +1 @@
-Subproject commit 4ffe21a516c38862da6c827b98fb2f242d1f66de
+Subproject commit 0ebf0fbe42c7ea1494d1a821275b9e20732310fc
++ git rev-parse HEAD
088ba13f214ac7b44b9b1f6daf6e159d649dfd88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants