Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle malformed SecOC key #1680

Open
aRossAllen opened this issue Jan 26, 2025 · 3 comments
Open

Handle malformed SecOC key #1680

aRossAllen opened this issue Jan 26, 2025 · 3 comments
Labels

Comments

@aRossAllen
Copy link

Describe the bug

R4P 2021 Toyota Comma 3x
After downloading ECU keys
Writning ECU Key to SecOCkey
Briefly working (3 weeks)
Then after a refflash
Install master-ci again would not run
Have tried sunny pilot, Master-ci but give same error.
Submitted ticket to Comma they took a look at my logs and said not a hardware issue with a screenshot with no expiation.
Suggested community support for this ?

Provide a route where the issue occurs

https://useradmin.comma.ai/?onebox=762a536115146c5d%7C00000001--f59a8f131c

openpilot version

0.9.8

Additional info

currently on SunnyPilot but thinking of trying FrogPilot

@aRossAllen aRossAllen added the bug label Jan 26, 2025
@adeebshihadeh
Copy link
Contributor

Closing as this isn't a bug - check out our Discord instead.

@jyoung8607
Copy link
Collaborator

jyoung8607 commented Jan 26, 2025

Something went wrong saving your key, openpilot can't parse it. If in doubt about the process, ask in #toyota-security, there have been some recent changes.

@sshane can you transfer this issue to opendbc? The user who opened the issue can fix themselves, but card should handle the ValueError exception without faceplanting.

{'errorLogMessage': '{"msg": "crash", "ctx": {"daemon": "card", "dongle_id": "762a536115146c5d", "version": "0.9.8", "origin": '
                    '"github.com/commaai/openpilot", "branch": "master-ci", "commit": "e083f2da795d0631cdbd6584fd548199d0aec02f", "dirty": false, '
                    '"device": "tizi"}, "exc_info": "Traceback (most recent call last):\\n  File '
                    '\\"/data/openpilot/openpilot/system/manager/process.py\\", line 41, in launcher\\n    mod.main()\\n  File '
                    '\\"/data/openpilot/selfdrive/car/card.py\\", line 274, in main\\n    car = Car()\\n          ^^^^^\\n  File '
                    '\\"/data/openpilot/selfdrive/car/card.py\\", line 129, in __init__\\n    saved_secoc_key = '
                    'bytes.fromhex(secoc_key.strip())\\n                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\\nValueError: non-hexadecimal number '
                    'found in fromhex() arg at position 0", "level": "ERROR", "levelnum": 40, "name": "swaglog", "filename": "process.py", "lineno": '
                    '47, "pathname": "/data/openpilot/openpilot/system/manager/process.py", "module": "process", "funcName": "launcher", "host": '
                    '"comma-8b8c4589", "process": 48981, "thread": 548488196128, "threadName": "MainThread", "created": 1735653149.0213544}',

@aRossAllen
Copy link
Author

Great - Thankyou for your help!!

@sshane sshane transferred this issue from commaai/openpilot Jan 30, 2025
@sshane sshane reopened this Jan 30, 2025
@sshane sshane changed the title openpilot Unavailable Waiting to start Handle malformed SecOC key Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants