Chrysler VIN fuzzy fingerprint #33000
Conversation
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
selfdrive/car/chrysler/values.py
Outdated
| # Check chassis code, engine and year to determine the platform | ||
| chassis_code = vin[4:6] | ||
| engine = vin[7] | ||
| year = vin[9] |
There was a problem hiding this comment.
Does the engine denote the trim/or if hybrid? Recently we're erring on the side of allowing more variants to fingerprint, if we reasonably expect them to work fine. For example, on Toyota the Corolla and Corolla Hybrid are treated the same. If the engine code here is supposed to split those, perhaps we don't need it.
There was a problem hiding this comment.
Yes it denotes hybrid
Ok so maybe we can rearrange the platforms into 2:
CHRYSLER_PACIFICA_2017 that contains 2017_HYBRID, 2018_HYBRID and 2018
CHRYSLER_PACIFICA_2020 that contains 2020 and 2019_HYBRID
CHRYSLER_PACIFICA_2020 needs to be different because handled differently in interface.py
|
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --rejectSimply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
May close commaai/opendbc#1092
Don't seem to be any pattern in fw versions that can give any hints except relative versioning so using VIN parsing like for VW
It seems that we can fully determine a Stellantis platform with chassis code (pos 4-5) + engine (pos 7) + year (pos 9)
Sources:
https://vpic.nhtsa.dot.gov/mid/home/displayfile/b5f541b7-8157-415d-889c-7f63628e9e66