Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton: add padding and update dashboard drawer close icon #13

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Jun 10, 2024

Old Icon

old-icon

New Icon

new-icon


Old icon button padding

old-spacing

New icon button padding

new-spacing

Changes made

  • New icon: onClose button should not be a menu icon which suggests another menu flow. It should be a back arrow which suggests the drawer to close and to return back to where you came from.
  • Added .5rem padding: Current buttons did not have any padding so when mouse hoovered or on press the icon would show the alternative state with little padding shown above.

Copy link

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

deployed preview: https://13.connect-d5y.pages.dev

@incognitojam incognitojam changed the title UI/Buttons: Changed onClose btn icon and added spacing IconButton: add padding and update dashboard drawer close icon Jun 11, 2024
@incognitojam incognitojam merged commit 3645972 into commaai:master Jun 11, 2024
1 check passed
@ugtthis ugtthis deleted the improved-menu-close-btn branch June 11, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants