Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview screenshots not up to date #152

Open
incognitojam opened this issue Feb 2, 2025 · 1 comment
Open

Preview screenshots not up to date #152

incognitojam opened this issue Feb 2, 2025 · 1 comment
Labels
bug Something isn't working CI / testing unit tests, CI, etc.

Comments

@incognitojam
Copy link
Member

incognitojam commented Feb 2, 2025 •
edited
Loading

I noticed on this PR the screenshots comment was updated but still showed the design before the most recent changes

#117 (comment)
https://github.com/commaai/new-connect/actions/runs/13099793681/job/36546592285

Maybe the take screenshots job should use the commit deploy URL instead of the branch/PR number URL?
e.g. https://d21260de.connect-d5y.pages.dev/ It could also be timing related, or something else
@incognitojam incognitojam added bug Something isn't working CI / testing unit tests, CI, etc. labels Feb 2, 2025
@incognitojam incognitojam mentioned this issue Feb 9, 2025
Merged
@incognitojam
Copy link
Member Author

incognitojam commented Feb 9, 2025 •
edited
Loading

There was a race condition if one preview job finishes after the next one, but the screenshots being outdated is also caused by browser cache. Might be necessary to add a random hash to the screenshot filenames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI / testing unit tests, CI, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@incognitojam