Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't seek after exiting zoom with mouse back button #534

Closed
sshane opened this issue Jun 24, 2024 · 3 comments · Fixed by #535
Closed

can't seek after exiting zoom with mouse back button #534

sshane opened this issue Jun 24, 2024 · 3 comments · Fixed by #535

Comments

@sshane
Copy link
Contributor

sshane commented Jun 24, 2024

from #486. back button in the UI works though

cant.seek.properly.with.mouse.back.mp4
@0x7B5
Copy link
Contributor

0x7B5 commented Jun 24, 2024

This is getting caused because state.loop doesn't get updated properly when using mouse back button. Looking into it rn.

@sshane
Copy link
Contributor Author

sshane commented Jun 24, 2024

The history middleware used to reset it to the route zoom range, but now it doesn't execute

@0x7B5
Copy link
Contributor

0x7B5 commented Jun 25, 2024

That PR should fix it. As a side note, combining zoom and loop is probably not a bad idea (#461).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants